Check the dimensions when making internal parameter connections #899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks internal parameter connections for dimension mismatches between source variables and destination parameters. Specifically we check that the length of each dimension in the parameter matches the length of the variable dimension in the corresponding position of the dimension list. In the future we can add checking of datatypes but for this PR we will isolate to dimensions and size issues.
TODO:
:time
dimension - we will check although we can assume they will match given other time dim checking along the way in Mimitest_all_models.jl