Add payload2 feature #887
Add payload2 feature #887
Conversation
There was a problem hiding this comment.
@davidanthoff looks good to me, I'd probably vote at some point for a name like payload_shallow or something ... but I'd have to think about what would be a good name :). This is very internal for now anyways so not too worried about it.
| # This is a bit convoluted, but we want to make sure to exclude payload2 from the deepcopy | ||
| # call here | ||
| payload2 = sim_def.payload2 | ||
| sim_def.payload2 = nothing | ||
| self.sim_def = deepcopy(sim_def) |
There was a problem hiding this comment.
Just so I'm clear here, what we're doing is (1) deep copy the sim_def without payloads (2) add the payload and the payload2 (3) replace the payload in the sim_def with a deep copied version
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
- Coverage 84.28% 84.24% -0.05%
==========================================
Files 40 40
Lines 3799 3808 +9
==========================================
+ Hits 3202 3208 +6
- Misses 597 600 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No description provided.