Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_timesteps
toupdate_params!
so that it throws a warning instead of an errorupdate_param!
on a model definition needs to usecopyto!
, otherwise we are breaking the connection between the model instance's component instance parameters (they use views for their TimestepArray data) and the model instance's model def's external parametershttps://forum.mimiframework.org/t/using-mimiiwg-jl/158