Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timesteps bugfix #809

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Update timesteps bugfix #809

merged 4 commits into from
Apr 8, 2021

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Apr 7, 2021

  • We need to add the (deprecated) keyword argument update_timesteps to update_params! so that it throws a warning instead of an error
  • update_param! on a model definition needs to use copyto!, otherwise we are breaking the connection between the model instance's component instance parameters (they use views for their TimestepArray data) and the model instance's model def's external parameters

https://forum.mimiframework.org/t/using-mimiiwg-jl/158

@lrennels lrennels self-assigned this Apr 7, 2021
@lrennels lrennels added this to the v1.2.1 milestone Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #809 (b2ff89b) into master (38ca256) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   83.95%   83.96%           
=======================================
  Files          39       39           
  Lines        3478     3479    +1     
=======================================
+ Hits         2920     2921    +1     
  Misses        558      558           
Flag Coverage Δ
unittests 83.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/model.jl 87.50% <ø> (ø)
src/core/connections.jl 88.35% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ca256...b2ff89b. Read the comment docs.

@lrennels lrennels merged commit 962a0c9 into master Apr 8, 2021
@lrennels lrennels deleted the update-timesteps-bugfix branch April 8, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants