-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Explorer for Non-Time Data #803
Conversation
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 82.90% 82.97% +0.06%
==========================================
Files 37 39 +2
Lines 3446 3466 +20
==========================================
+ Hits 2857 2876 +19
- Misses 589 590 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is that getting the JSONText for the different plot types seems somewhat repetitively, but I also can't see a better way of doing it, so this looks good!
@arnavgautam I agree that really should be revisited! |
#651