Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Explorer for Non-Time Data #803

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Improve Explorer for Non-Time Data #803

merged 7 commits into from
Mar 30, 2021

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Mar 16, 2021

@lrennels lrennels changed the title Add scatter plot to explorer Improve Explorer for Non-Time Data Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #803 (fdf6bf9) into master (9e28b76) will increase coverage by 0.06%.
The diff coverage is 97.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   82.90%   82.97%   +0.06%     
==========================================
  Files          37       39       +2     
  Lines        3446     3466      +20     
==========================================
+ Hits         2857     2876      +19     
- Misses        589      590       +1     
Flag Coverage Δ
unittests 82.97% <97.70%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/explorer/explore.jl 60.29% <ø> (ø)
src/explorer/buildmenu.jl 94.73% <94.73%> (ø)
src/explorer/buildspecs.jl 94.66% <100.00%> (-0.77%) ⬇️
src/explorer/getdataparts.jl 100.00% <100.00%> (ø)
src/core/defcomp.jl 82.02% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e28b76...fdf6bf9. Read the comment docs.

@lrennels lrennels requested a review from arnavgautam March 17, 2021 00:38
@lrennels lrennels marked this pull request as ready for review March 18, 2021 06:02
Copy link
Collaborator

@arnavgautam arnavgautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that getting the JSONText for the different plot types seems somewhat repetitively, but I also can't see a better way of doing it, so this looks good!

@lrennels
Copy link
Collaborator Author

@arnavgautam I agree that really should be revisited!

@lrennels lrennels merged commit 8d8ec3b into master Mar 30, 2021
@lrennels lrennels deleted the explorer branch March 30, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants