Merge pull request #968 from mimiframework/perf

Improve performance
mimiframework · Jul 17, 2023 · eb15661 · eb15661
2 parents 5064cab + 7e4b216
commit eb15661
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/utils/getdataframe.jl b/src/utils/getdataframe.jl
@@ -24,7 +24,7 @@ function _load_dataframe(m::AbstractModel, comp_name::Symbol, item_name::Symbol,
     end
     paths = m isa MarginalModel ? _get_all_paths(m.base) : _get_all_paths(m)
     comp_path = paths[comp_name];
-    data = deepcopy(m[comp_path, item_name] === nothing ? m[comp_name, item_name] : m[comp_path, item_name])
+    data = m[comp_path, item_name] === nothing ? m[comp_name, item_name] : m[comp_path, item_name]
 
     if num_dims == 1
         dim1name = dims[1]
@@ -46,7 +46,7 @@ function _load_dataframe(m::AbstractModel, comp_name::Symbol, item_name::Symbol,
             # @info "len shifted: $(length(shifted_data))"
             df[!, item_name] = shifted_data
         else
-            df[!, item_name] = data
+            df[!, item_name] = deepcopy(data)
         end
     else
         df = _df_helper(m, comp_name, item_name, dims, data)
@@ -86,7 +86,7 @@ function _df_helper(m::AbstractModel, comp_name::Symbol, item_name::Symbol, dims
             data = vcat(top, data, bottom)
         end
 
-        df[!, item_name] = cat([vec(data[i, :]) for i = 1:len_dim1]...; dims=1)
+        df[!, item_name] = collect(vec(data'))
     else
 
         # shift the data to be padded with missings if this data is shorter than the model