Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggsig api verify_single() security enhancement #24

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

garyyu
Copy link
Contributor

@garyyu garyyu commented Aug 26, 2018

Fix for mimblewimble/grin#1356.

verify_single() security enhancement, for the case of value 0 as as public key.

And add a test case test_aggsig_fuzz. The test output:

$ cargo test --release test_aggsig_fuzz -- --nocapture

running 1 test
Performing aggsig single context with seckey, pubkey: SecretKey(37a7157bc614991e8d9b098010849bb8ad45086c2287f474a55865c56580c0d4),PublicKey(588265989752a87a4f7a35c2257fe4f779d7ddf351825271f5513311ac21c70cecb2f396882b43c2f78e00fc70ceb1654775f24ee0365a08978f12375ef81b67)
Verifying aggsig single: Signature(8b1a8df756f12d2900d34ec56ceaaa39cbd1ddeaead238d9e60be10b9053b0790000000000000000000000000000000000000000000000000000000000000000), msg: Message(cae4239ebe56a791b207302882bf6047d5fc49c277ae9a96938fa3f6e1036516), pk:PublicKey(588265989752a87a4f7a35c2257fe4f779d7ddf351825271f5513311ac21c70cecb2f396882b43c2f78e00fc70ceb1654775f24ee0365a08978f12375ef81b67)
Signature verification single (correct): false
Verifying aggsig single: Signature(000000000000000000000000000000000000000000000000000000000000000043e63e417bddbdfc91da3f27b6b7995e15335f79df94b5982c5b765b2b991c9c), msg: Message(cae4239ebe56a791b207302882bf6047d5fc49c277ae9a96938fa3f6e1036516), pk:PublicKey(588265989752a87a4f7a35c2257fe4f779d7ddf351825271f5513311ac21c70cecb2f396882b43c2f78e00fc70ceb1654775f24ee0365a08978f12375ef81b67)
Signature verification single (correct): false
Verifying aggsig single: Signature(8b1a8df756f12d2900d34ec56ceaaa39cbd1ddeaead238d9e60be10b9053b07943e63e417bddbdfc91da3f27b6b7995e15335f79df94b5982c5b765b2b991c9c), msg: Message(cae4239ebe56a791b207302882bf6047d5fc49c277ae9a96938fa3f6e1036516), pk:PublicKey(00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000)
Signature verification single (correct): false
Verifying aggsig single: Signature(8b1a8df756f12d2900d34ec56ceaaa39cbd1ddeaead238d9e60be10b9053b07943e63e417bddbdfc91da3f27b6b7995e15335f79df94b5982c5b765b2b991c9c), msg: Message(cae4239ebe56a791b207302882bf6047d5fc49c277ae9a96938fa3f6e1036516), pk:PublicKey(0000000000000000000000000000000000000000000000000000000000000000ecb2f396882b43c2f78e00fc70ceb1654775f24ee0365a08978f12375ef81b67)
Signature verification single (correct): false
test aggsig::tests::test_aggsig_fuzz ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 48 filtered out

src/aggsig.rs Outdated
@@ -111,6 +111,10 @@ pub fn verify_single(secp: &Secp256k1, sig:&Signature, msg:&Message, pubnonce:Op
false => 0,
};

if (sig.0).0.ends_with(&[0u8; 32]) || (pubkey.0).0.starts_with(&[0u8; 32]) {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@yeastplume
Copy link
Member

Looks good, will create a new tag now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants