Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify by avoiding unnecessary conversions #3343

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

tromp
Copy link
Contributor

@tromp tromp commented Jun 7, 2020

Simplify Cuckaroo{,d,m,z} verification logic, by avoiding unnecessary conversions between u64 and edge type.
Tested on fast sync of floonet.

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look and didn't see anything wrong at first sight. Same as before with less conversions. So I'd say 👍 LGTM.

@quentinlesceller quentinlesceller merged commit e28e02e into mimblewimble:master Jun 8, 2020
@lehnberg lehnberg added this to the 4.0.0 milestone Jun 9, 2020
quentinlesceller added a commit to blockcypher/libgrin that referenced this pull request Jun 15, 2020
quentinlesceller added a commit to blockcypher/libgrin that referenced this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants