-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable faster sync #3108
Enable faster sync #3108
Conversation
8f9ebe6
to
6fe57ad
Compare
We now log this for every new block -
It would be good to get this merged and have multiple nodes deployed with this code so we can verify the Note: We are not currently using the |
@antiochp taking a look |
will look over this weekend
…On Fri, Nov 15, 2019 at 3:28 PM Quentin Le Sceller ***@***.***> wrote:
@antiochp <https://github.com/antiochp> taking a look today.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#3108?email_source=notifications&email_token=AAR5BW4LUYNEZHSVQDG3HULQT2W2BA5CNFSM4JIVEHQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEFSSMQ#issuecomment-554379570>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5BWZBBQODADE5YPXIWQ3QT2W2BANCNFSM4JIVEHQA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added some comments and questions to the code diffs.
a3bae98
to
57d5782
Compare
refactor vec backend so we can use it outside of tests introduce a "hash only" vec backend for the accumulator
I'm going to merge this now. It adds the accumulator without relying on it yet. And adds logging around the accumulator which I'd like to start seeing on multiple nodes on |
Non-consensus related implementation for RFC mimblewimble/grin-rfcs#29
vec_backend
so we can use it outside of testsvec_backend
for the accumulatorbitmap_accumulator
-We will eventually be able to use this bitmap accumulator root to verify fragments of the leafset against subtrees of the existing output PMMR. This will allow us to verify "fast sync" data in chunks, without needing to download the full
txhashset.zip
which is increasingly becoming a bottleneck and single point of failure during initial fast sync.TODO -