-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer serializations #18
Safer serializations #18
Conversation
Going in the right direction, you're right about removing the from_vec constructors. I just don't like adding all those specialized readers and dependencies in ser.rs and the related base traits. How about doing Proof::read or Hash::read instead of read_proof and read_hash? |
review please. Can't move Commitment and RangeProof out of ser.rs as doing so would introduce cyclical dependency between core and secp. |
As there were a lot of small additive changes I ended up squashing the merge to keep the history cleaner. Hope you don't mind. |
That was the right thing to do, thank you. |
Thanks for another great pull request! |
Safer serializations.
Removed xx:from_vec constructors as they did not check length or paniced.