Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer serializations #18

Merged
merged 15 commits into from
Dec 17, 2016

Conversation

GarrickOllivander
Copy link
Contributor

Safer serializations.
Removed xx:from_vec constructors as they did not check length or paniced.

@ignopeverell
Copy link
Contributor

Going in the right direction, you're right about removing the from_vec constructors. I just don't like adding all those specialized readers and dependencies in ser.rs and the related base traits. How about doing Proof::read or Hash::read instead of read_proof and read_hash?

@GarrickOllivander
Copy link
Contributor Author

review please. Can't move Commitment and RangeProof out of ser.rs as doing so would introduce cyclical dependency between core and secp.

@ignopeverell ignopeverell merged commit 2e6d3d9 into mimblewimble:master Dec 17, 2016
@ignopeverell
Copy link
Contributor

As there were a lot of small additive changes I ended up squashing the merge to keep the history cleaner. Hope you don't mind.

@GarrickOllivander GarrickOllivander deleted the serializations branch December 18, 2016 08:40
@GarrickOllivander
Copy link
Contributor Author

That was the right thing to do, thank you.

@ignopeverell
Copy link
Contributor

Thanks for another great pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants