Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update requirements #943

Closed

Conversation

filipecaixeta
Copy link

@filipecaixeta filipecaixeta commented Apr 4, 2022

For some reason, all the requirements have a fixed version
The main dependencies for pymilvus are the grpc packages so I fixed a minimum and maximum version
I'm having problems installing pymilvus with other google libraries because pymilvus has a fixed version with an old version of grpc libraries.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: filipecaixeta
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Filipe Caixeta <[email protected]>
@filipecaixeta
Copy link
Author

/assign @XuanYang-cn

@Jacobh2
Copy link

Jacobh2 commented May 12, 2022

Any updates on this? 😄 Would be nice to get in, we're using grpcio lib for other reasons in combo with PyMilvus, where we need the higher versions!

@mergify mergify bot added the dco-passed label May 19, 2022
@aditya-nambiar
Copy link

Any update on this ? I'm unable to install pymilvus cause of grpcio 1.37 fails but i am able to install a higher version 1.46

XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 16, 2022
To run pymilvus, we only need `grpcio`
To generate python files from protos, we need `grpcio-tools`

This PR:
1. Removes `grpcio-tools` from install requirements
2. Extends `grpcio` versions
3. Provides the compatible version ranges of `grpcio-tools` and `grpcio`

See also: milvus-io#1030, milvus-io#943, milvus-io#946

Signed-off-by: XuanYang-cn <[email protected]>
@XuanYang-cn
Copy link
Contributor

#1033 would fix this problem, thanks for this PR

sre-ci-robot pushed a commit that referenced this pull request Jun 16, 2022
To run pymilvus, we only need `grpcio`
To generate python files from protos, we need `grpcio-tools`

This PR:
1. Removes `grpcio-tools` from install requirements
2. Extends `grpcio` versions
3. Provides the compatible version ranges of `grpcio-tools` and `grpcio`

See also: #1030, #943, #946

Signed-off-by: XuanYang-cn <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2022
To run pymilvus, we only need `grpcio`
To generate python files from protos, we need `grpcio-tools`

This PR:
1. Removes `grpcio-tools` from install requirements
2. Extends `grpcio` versions
3. Provides the compatible version ranges of `grpcio-tools` and `grpcio`

See also: milvus-io#1030, milvus-io#943, milvus-io#946

Signed-off-by: XuanYang-cn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants