-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update requirements #943
update requirements #943
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: filipecaixeta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Filipe Caixeta <[email protected]>
6a80ebe
to
71c4c5f
Compare
/assign @XuanYang-cn |
Any updates on this? 😄 Would be nice to get in, we're using |
Any update on this ? I'm unable to install pymilvus cause of grpcio 1.37 fails but i am able to install a higher version 1.46 |
To run pymilvus, we only need `grpcio` To generate python files from protos, we need `grpcio-tools` This PR: 1. Removes `grpcio-tools` from install requirements 2. Extends `grpcio` versions 3. Provides the compatible version ranges of `grpcio-tools` and `grpcio` See also: milvus-io#1030, milvus-io#943, milvus-io#946 Signed-off-by: XuanYang-cn <[email protected]>
#1033 would fix this problem, thanks for this PR |
To run pymilvus, we only need `grpcio` To generate python files from protos, we need `grpcio-tools` This PR: 1. Removes `grpcio-tools` from install requirements 2. Extends `grpcio` versions 3. Provides the compatible version ranges of `grpcio-tools` and `grpcio` See also: #1030, #943, #946 Signed-off-by: XuanYang-cn <[email protected]>
To run pymilvus, we only need `grpcio` To generate python files from protos, we need `grpcio-tools` This PR: 1. Removes `grpcio-tools` from install requirements 2. Extends `grpcio` versions 3. Provides the compatible version ranges of `grpcio-tools` and `grpcio` See also: milvus-io#1030, milvus-io#943, milvus-io#946 Signed-off-by: XuanYang-cn <[email protected]>
For some reason, all the requirements have a fixed version
The main dependencies for pymilvus are the grpc packages so I fixed a minimum and maximum version
I'm having problems installing pymilvus with other google libraries because pymilvus has a fixed version with an old version of grpc libraries.