Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add search iterator v2 #2395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: add search iterator v2 #2395

wants to merge 1 commit into from

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Nov 29, 2024

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PwzXxm
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Nov 29, 2024 •
edited
Loading

/hold
wait for milvus PR milvus-io/milvus#37947 to be merged first

@mergify mergify bot added the dco-passed label Nov 29, 2024
@PwzXxm PwzXxm mentioned this pull request Nov 29, 2024
Open
1 task
@mergify mergify bot added the ci-passed label Nov 29, 2024
XuanYang-cn
XuanYang-cn reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically LGTM

But I have a compactibility concern: Collection.SearchIterator added a "use_v1 = False", new PyMilvus with old Milvus might raise Exceptions directly.

@PwzXxm
enhance: add search iterator v2
34c1887 
Signed-off-by: Patrick Weizhi Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn left review comments

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees
No one assigned
Labels
ci-passed dco-passed do-not-merge/hold size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PwzXxm @sre-ci-robot @XuanYang-cn