Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: grant/revoke v2 optional db and collection params #2386

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

shaoting-huang
Copy link
Contributor

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Nov 28, 2024
@XuanYang-cn
Copy link
Contributor

2.5 and 2.4 needed too

@sre-ci-robot sre-ci-robot merged commit 053c568 into milvus-io:master Nov 28, 2024
11 checks passed
shaoting-huang added a commit to shaoting-huang/pymilvus that referenced this pull request Nov 28, 2024
shaoting-huang added a commit to shaoting-huang/pymilvus that referenced this pull request Nov 28, 2024
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Nov 28, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants