Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Bulkinsert support csv #2247

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

OxalisCu
Copy link
Contributor

@OxalisCu OxalisCu commented Sep 2, 2024

Milvus has supported csv format in bulkinsert, this pr synchronizes this support to pymilvus.
See this pr in milvus for detail information milvus-io/milvus#34938

@sre-ci-robot
Copy link

Welcome @OxalisCu! It looks like this is your first PR to milvus-io/pymilvus 🎉

@OxalisCu OxalisCu force-pushed the bulkinsert-support-csv branch from 92b507b to 7b33c2c Compare September 4, 2024 10:46
@XuanYang-cn
Copy link
Contributor

/assign @yhmo

@yhmo
Copy link
Contributor

yhmo commented Sep 5, 2024

The code change looks good to me.
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OxalisCu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 87da0f1 into milvus-io:master Sep 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants