Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update milvus-proto and correct index.drop() #2142

Merged
merged 2 commits into from
Jun 18, 2024
Merged

enhance: update milvus-proto and correct index.drop() #2142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d76a05
enhance: update milvus-proto and correct index.drop()
XuanYang-cn Jun 18, 2024
e7985b5
fix mergify
XuanYang-cn Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ pull_request_rules:
- or:
- base=master
- base~=2\.\d
- "status-success=Run Python Tests (3.8)"
- "status-success=Run Python Tests (3.8, windows-latest)"
- "status-success=Run Python Tests (3.12, windows-latest)"
- "status-success=Run Python Tests (3.8, ubuntu-latest)"
- "status-success=Run Python Tests (3.12, ubuntu-latest)"
- "status-success=Run Check Proto (3.8)"
- "status-success=Code lint check (3.8)"
- "status-success=Run Python Tests (3.12)"
- "status-success=Run Check Proto (3.12)"
- "status-success=Code lint check (3.12)"
actions:
Expand Down
7 changes: 2 additions & 5 deletions pymilvus/orm/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@ def __init__(
self._collection = collection
self._field_name = field_name
self._index_params = index_params
index_name = kwargs.get("index_name", Config.IndexName)
self._index_name = index_name
self._kwargs = kwargs
if self._kwargs.pop("construct_only", False):
self._index_name = kwargs.get("index_name", Config.IndexName)
if kwargs.get("construct_only", False):
return

conn = self._get_connection()
Expand Down Expand Up @@ -137,5 +135,4 @@ def drop(self, timeout: Optional[float] = None, **kwargs):
field_name=self.field_name,
index_name=self.index_name,
timeout=timeout,
**kwargs,
)