Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sparse related errors to ParamError #2066

Merged

Conversation

zhengbuqian
Copy link
Collaborator

so that the error messages can correctly propagate

@XuanYang-cn
Copy link
Contributor

wait for #2068

@buqian-zilliz buqian-zilliz force-pushed the sparse-pymilvus-improvement branch from 4edcb52 to bdd1962 Compare May 7, 2024 08:18
@XuanYang-cn
Copy link
Contributor

@zhengbuqian Code checker is fixed at the latest codes, please rebase and force push again, Thx

@buqian-zilliz buqian-zilliz force-pushed the sparse-pymilvus-improvement branch from bdd1962 to fe14c32 Compare May 7, 2024 08:28
@XuanYang-cn XuanYang-cn added the PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x label May 7, 2024
@mergify mergify bot added the ci-passed label May 7, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 97f12ae into milvus-io:master May 7, 2024
9 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 7, 2024
@zhengbuqian zhengbuqian deleted the sparse-pymilvus-improvement branch May 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants