-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Wrong typehint for describe_role #2332
Comments
/assign @CaoHaiNam |
@XuanYang-cn: GitHub didn't allow me to assign the following users: CaoHaiNam. Note that only milvus-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
related: [#2332](#2332) --------- Signed-off-by: NamCaoHai <[email protected]>
- Added grpc as a valid protocol for uri (milvus-io#2090) - build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140) - build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170) - feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192) - feat: Add compact, get_server_version and flush api (milvus-io#2326) - Fix typo and correct grammar (milvus-io#2333) - Update return type of describe_role to Dict (milvus-io#2337) - enhance: Reorganize the examples (milvus-io#2340) Related: milvus-io#2166, milvus-io#2325, milvus-io#2332 Co-authored-by: Bruno Faria <[email protected]> Co-authored-by: Bruno Faria <[email protected]> Co-authored-by: dependabot[bot] <[email protected]> Co-authored-by: -LAN- <[email protected]> Co-authored-by: zhenshan.cao <[email protected]> Co-authored-by: NamCaoHai <[email protected]> Co-authored-by: yangxuan <[email protected]>
- Added grpc as a valid protocol for uri (milvus-io#2090) - build(deps): bump urllib3 from 1.26.18 to 1.26.19 (milvus-io#2140) - build(deps): bump certifi from 2023.7.22 to 2024.7.4 (milvus-io#2170) - feat(pymilvus/settings.py): Load configuration without altering the environment (milvus-io#2192) - feat: Add compact, get_server_version and flush api (milvus-io#2326) - Fix typo and correct grammar (milvus-io#2333) - Update return type of describe_role to Dict (milvus-io#2337) - enhance: Reorganize the examples (milvus-io#2340) Related: milvus-io#2166, milvus-io#2325, milvus-io#2332 Co-authored-by: Bruno Faria <[email protected]> Co-authored-by: Bruno Faria <[email protected]> Co-authored-by: dependabot[bot] <[email protected]> Co-authored-by: -LAN- <[email protected]> Co-authored-by: zhenshan.cao <[email protected]> Co-authored-by: NamCaoHai <[email protected]> Co-authored-by: yangxuan <[email protected]> Signed-off-by: yangxuan <[email protected]>
/close |
@XuanYang-cn: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Added grpc as a valid protocol for uri (#2090) - build(deps): bump urllib3 from 1.26.18 to 1.26.19 (#2140) - build(deps): bump certifi from 2023.7.22 to 2024.7.4 (#2170) - feat(pymilvus/settings.py): Load configuration without altering the environment (#2192) - feat: Add compact, get_server_version and flush api (#2326) - Fix typo and correct grammar (#2333) - Update return type of describe_role to Dict (#2337) - enhance: Reorganize the examples (#2340) Related: #2166, #2325, #2332 Signed-off-by: yangxuan <[email protected]> Co-authored-by: Bruno Faria <[email protected]> Co-authored-by: Bruno Faria <[email protected]> Co-authored-by: dependabot[bot] <[email protected]> Co-authored-by: -LAN- <[email protected]> Co-authored-by: zhenshan.cao <[email protected]> Co-authored-by: NamCaoHai <[email protected]>
Is there an existing issue for this?
Describe the bug
When calling
client.describe_role(role_name=some_role)
, the function returns a dictionary, and this is pretty clear from the code:pymilvus/pymilvus/milvus_client/milvus_client.py
Lines 967 to 979 in 650f7cd
However, the function signature indicates the returned value is
List[Dict]
.Expected Behavior
The function signature should simply indicate the returned value is
Dict
, orDict[str, Any]
.Steps/Code To Reproduce behavior
Environment details
Anything else?
I know this seems minor, but with type checkers like pyright, I assure you this kind of problem is a bit confusing.
The text was updated successfully, but these errors were encountered: