Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update segcore for VECTOR_INT8 #39415

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jan 18, 2025

Issue: #38666

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Jan 18, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 18, 2025
Copy link
Contributor

mergify bot commented Jan 18, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 52.29358% with 52 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (5b35fc7) to head (a6f8a48).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/Util.cpp 20.00% 16 Missing ⚠️
internal/core/src/common/ChunkWriter.cpp 0.00% 13 Missing ⚠️
internal/core/src/index/IndexFactory.cpp 0.00% 6 Missing ⚠️
internal/core/src/common/Types.h 50.00% 5 Missing ⚠️
internal/core/src/query/SearchBruteForce.cpp 76.47% 4 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 3 Missing ⚠️
internal/core/src/segcore/Utils.cpp 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39415      +/-   ##
==========================================
- Coverage   81.00%   81.00%   -0.01%     
==========================================
  Files        1408     1408              
  Lines      198563   198639      +76     
==========================================
+ Hits       160849   160900      +51     
- Misses      32052    32080      +28     
+ Partials     5662     5659       -3     
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.48% <52.29%> (+<0.01%) ⬆️
Go 82.94% <ø> (ø)
Files with missing lines Coverage Δ
internal/core/src/common/FieldData.cpp 78.75% <ø> (ø)
internal/core/src/common/FieldData.h 100.00% <100.00%> (ø)
internal/core/src/common/Utils.h 90.32% <ø> (-0.50%) ⬇️
internal/core/src/query/ExecPlanNodeVisitor.cpp 100.00% <100.00%> (ø)
internal/core/src/query/ExecPlanNodeVisitor.h 100.00% <ø> (ø)
internal/core/src/query/PlanNode.cpp 100.00% <100.00%> (ø)
internal/core/src/query/PlanNode.h 100.00% <100.00%> (ø)
internal/core/src/query/PlanProto.cpp 88.57% <100.00%> (+0.06%) ⬆️
internal/core/src/segcore/ConcurrentVector.cpp 97.01% <100.00%> (+0.09%) ⬆️
internal/core/src/segcore/ConcurrentVector.h 95.97% <100.00%> (+0.11%) ⬆️
... and 11 more

... and 35 files with indirect coverage changes

@cydrain
Copy link
Contributor Author

cydrain commented Jan 19, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 19, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain
Copy link
Contributor Author

cydrain commented Jan 19, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 19, 2025
@sunby
Copy link
Contributor

sunby commented Jan 20, 2025

/lgtm

Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, cydrain, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 341d6c1 into milvus-io:master Jan 21, 2025
19 of 20 checks passed
@cydrain cydrain deleted the caiyd_38666_support_int8_vector_segcore branch January 21, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants