Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add privilege group privilege into built-in privilege group #38393

Merged

Conversation

shaoting-huang
Copy link
Contributor

related issue: #37031

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 12, 2024
Copy link
Contributor

mergify bot commented Dec 12, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (a514f83) to head (6890d78).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/constant.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38393      +/-   ##
==========================================
- Coverage   80.93%   80.90%   -0.03%     
==========================================
  Files        1376     1376              
  Lines      193056   193058       +2     
==========================================
- Hits       156246   156194      -52     
- Misses      31298    31340      +42     
- Partials     5512     5524      +12     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.92% <ø> (ø)
Go 83.01% <83.33%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
pkg/util/constant.go 96.82% <83.33%> (-1.54%) ⬇️

... and 32 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 12, 2024
Copy link
Contributor

mergify bot commented Dec 12, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 12, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 12, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c2855a5 into milvus-io:master Dec 12, 2024
19 of 20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 12, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 12, 2024
…group (#38408)

cherry-pick from master: #38393
related issue: #37031

Signed-off-by: shaoting-huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants