Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Resolve compilation error due to PR conflict #38252

Merged

Conversation

congqixia
Copy link
Contributor

Related pr: #38233 #38059

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 December 5, 2024 10:39
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 5, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 5, 2024
@yanliang567
Copy link
Contributor

manual pass for fix compiling issue

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6ff1948 into milvus-io:master Dec 5, 2024
12 of 14 checks passed
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (051bc28) to head (2a7149d).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38252       +/-   ##
===========================================
+ Coverage   68.85%   82.97%   +14.12%     
===========================================
  Files         289     1083      +794     
  Lines       25508   165957   +140449     
===========================================
+ Hits        17563   137710   +120147     
- Misses       7945    22764    +14819     
- Partials        0     5483     +5483     
Components Coverage Δ
Client 74.43% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.22% <ø> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_release.go 80.00% <ø> (ø)

... and 1371 files with indirect coverage changes

@congqixia congqixia deleted the enhance/resolve_conf_38233_38059 branch December 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants