Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Grant v2 proxy service supports operatePrivilegeV2 #37997

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Nov 25, 2024

should support operatePrivilegeV2 service on Proxy to let SDK utilizes
cherry-pick from master: #37945
issue: #37031

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (e928e15) to head (1245ae5).
Report is 8 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/distributed/proxy/service.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37997      +/-   ##
==========================================
+ Coverage   80.62%   80.63%   +0.01%     
==========================================
  Files        1070     1070              
  Lines      167379   167377       -2     
==========================================
+ Hits       134942   134963      +21     
+ Misses      28008    27994      -14     
+ Partials     4429     4420       -9     
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.96% <100.00%> (-0.02%) ⬇️
internal/distributed/proxy/service.go 84.92% <0.00%> (-0.23%) ⬇️

... and 33 files with indirect coverage changes

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 added this to the 2.4.18 milestone Nov 26, 2024
@shaoting-huang shaoting-huang changed the title fix: [2.4] Grant v2 service fix fix: [2.4] Grant v2 proxy service supports operatePrivilegeV2 Nov 26, 2024
@shaoting-huang shaoting-huang changed the title fix: [2.4] Grant v2 proxy service supports operatePrivilegeV2 enhance: [2.4] Grant v2 proxy service supports operatePrivilegeV2 Nov 26, 2024
@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
need fix e2e

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 26, 2024
@sre-ci-robot sre-ci-robot merged commit 6088a1f into milvus-io:2.4 Nov 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants