Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: speed up search iterator stage 1 #37947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

enhance: speed up search iter stage 1

9016c4a
Select commit
Loading
Failed to load commit list.
Open

enhance: speed up search iterator stage 1 #37947

enhance: speed up search iter stage 1
9016c4a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

80.98% (target 77.00%)

View this Pull Request on Codecov

80.98% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 87.56757% with 46 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (5394f47) to head (9016c4a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/SearchOnSealed.cpp 36.84% 12 Missing ⚠️
internal/core/src/query/CachedSearchIterator.cpp 95.85% 7 Missing ⚠️
internal/proxy/search_util.go 89.55% 5 Missing and 2 partials ⚠️
internal/core/src/query/PlanProto.cpp 16.66% 5 Missing ⚠️
internal/core/src/query/SearchBruteForce.cpp 80.95% 4 Missing ⚠️
internal/core/src/query/SearchOnGrowing.cpp 42.85% 4 Missing ⚠️
internal/core/src/query/SearchOnIndex.cpp 42.85% 4 Missing ⚠️
internal/core/src/index/Utils.cpp 88.23% 2 Missing ⚠️
internal/core/src/query/CachedSearchIterator.h 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37947       +/-   ##
===========================================
+ Coverage   69.32%   80.98%   +11.65%     
===========================================
  Files         292     1381     +1089     
  Lines       26183   194670   +168487     
===========================================
+ Hits        18152   157644   +139492     
- Misses       8031    31463    +23432     
- Partials        0     5563     +5563
Components Coverage Δ
Client 75.27% <ø> (∅)
Core 69.44% <85.50%> (+0.11%) ⬆️
Go 83.02% <93.06%> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/QueryInfo.h 100.00% <100.00%> (ø)
internal/core/src/index/Utils.h 88.88% <ø> (ø)
internal/core/src/index/VectorDiskIndex.cpp 76.96% <100.00%> (-1.05%) ⬇️
internal/core/src/index/VectorMemIndex.cpp 64.80% <100.00%> (-0.35%) ⬇️
internal/proxy/proxy.go 71.30% <100.00%> (ø)
internal/proxy/task.go 80.69% <ø> (ø)
internal/proxy/task_search.go 76.34% <100.00%> (ø)
internal/core/src/query/CachedSearchIterator.h 95.00% <95.00%> (ø)
internal/core/src/index/Utils.cpp 40.90% <88.23%> (+3.96%) ⬆️
internal/core/src/query/SearchBruteForce.cpp 79.72% <80.95%> (-0.85%) ⬇️
... and 6 more

... and 1084 files with indirect coverage changes

View more details on Codecov