Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Check ANN field loaded in proxy #36172

Merged

Conversation

congqixia
Copy link
Contributor

Related to #35415

Currently ANN field is loaded in Parital load is not performed in proxy, this cause error message not clear and no error returned when collection is empty

Related to milvus-io#35415

Currently ANN field is loaded in Parital load is not performed in proxy,
this cause error message not clear and no error returned when collection
is empty

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Sep 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 11, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Sep 11, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@229f969). Learn more about missing BASE report.
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/parser/planparserv2/plan_parser_v2.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36172   +/-   ##
=========================================
  Coverage          ?   81.44%           
=========================================
  Files             ?     1273           
  Lines             ?   151712           
  Branches          ?        0           
=========================================
  Hits              ?   123559           
  Misses            ?    23252           
  Partials          ?     4901           
Files with missing lines Coverage Δ
internal/parser/planparserv2/plan_parser_v2.go 86.95% <0.00%> (ø)

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Sep 11, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 11, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 700a443 into milvus-io:master Sep 11, 2024
15 of 16 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Sep 11, 2024
Related to milvus-io#35415

Currently ANN field is loaded in Parital load is not performed in proxy,
this cause error message not clear and no error returned when collection
is empty

---------

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Sep 12, 2024
Cherry-pick from master
pr: #36172
Related to #35415

Currently ANN field is loaded in Parital load is not performed in proxy,
this cause error message not clear and no error returned when collection
is empty

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/check_ann_field_loaded branch September 12, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants