Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add part of test cases for default and null support #36130

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

binbinlv
Copy link
Contributor

@binbinlv binbinlv commented Sep 9, 2024

issue: #36129

@binbinlv binbinlv added this to the 2.5.0 milestone Sep 9, 2024
@binbinlv binbinlv requested a review from yanliang567 September 9, 2024 12:10
@sre-ci-robot sre-ci-robot added area/test sig/testing size/L Denotes a PR that changes 100-499 lines. labels Sep 9, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Sep 9, 2024
Copy link
Contributor

mergify bot commented Sep 9, 2024

@binbinlv

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@binbinlv binbinlv changed the title Add part of test cases for default and null support test: Add part of test cases for default and null support Sep 9, 2024
Copy link
Contributor

mergify bot commented Sep 9, 2024

@binbinlv E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Sep 10, 2024
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Sep 10, 2024
@mergify mergify bot removed the ci-passed label Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 10, 2024

@binbinlv E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 10, 2024

@binbinlv E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: binbinlv, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d9c8d1e into milvus-io:master Sep 11, 2024
6 checks passed
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants