Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Check load fields for previous loaded collection (#35905) #35910

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35905
Related to #35415

This PR make querycoord report error when load request tries to update load fields list, which is currently not supported.

…35905)

Related to milvus-io#35415

This PR make querycoord report error when load request tries to update
load fields list, which is currently not supported.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot requested review from sunby and yah01 September 2, 2024 11:21
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels Sep 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Sep 2, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (268c60c) to head (b3efc4c).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35910      +/-   ##
==========================================
- Coverage   84.99%   81.16%   -3.84%     
==========================================
  Files         789     1056     +267     
  Lines      115091   139375   +24284     
==========================================
+ Hits        97818   113117   +15299     
- Misses      12977    21954    +8977     
- Partials     4296     4304       +8     
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_load.go 90.83% <100.00%> (+0.48%) ⬆️

... and 294 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit df8d1c7 into milvus-io:2.4 Sep 3, 2024
15 checks passed
@congqixia congqixia deleted the cp24/35905 branch September 3, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants