Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Check clustering key skip load behavior (#35865) #35899

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35865
feature issue: #35415
See also #35861

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 2, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base (8b70612) to head (917cbe1).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35899      +/-   ##
==========================================
+ Coverage   71.94%   81.20%   +9.25%     
==========================================
  Files        1056     1056              
  Lines      139340   139363      +23     
==========================================
+ Hits       100254   113169   +12915     
+ Misses      34787    21914   -12873     
+ Partials     4299     4280      -19     
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 92.88% <100.00%> (+0.04%) ⬆️
internal/proxy/util.go 91.95% <100.00%> (+0.18%) ⬆️
pkg/util/typeutil/schema.go 85.84% <100.00%> (+0.19%) ⬆️

... and 232 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 2, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Sep 2, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 268c60c into milvus-io:2.4 Sep 2, 2024
15 checks passed
@congqixia congqixia deleted the cp24/35865 branch September 2, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants