Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support field partial load collection #35416

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

congqixia
Copy link
Contributor

Related to #35415

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. area/internal-api labels Aug 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Aug 11, 2024
@congqixia congqixia changed the title feat: Support horizontal partial load collection feat: Support field partial load collection Aug 11, 2024
@congqixia congqixia force-pushed the feat/horizontal_partial_load branch from db3c681 to 9ac7be6 Compare August 13, 2024 07:06
Copy link
Contributor

mergify bot commented Aug 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test sig/testing size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 13, 2024
Copy link
Contributor

mergify bot commented Aug 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the feat/horizontal_partial_load branch 2 times, most recently from ea467e9 to e3add14 Compare August 13, 2024 12:40
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 83.51648% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (4d69898) to head (bd8f499).
Report is 8 commits behind head on master.

Files Patch % Lines
internal/proxy/meta_cache.go 87.09% 5 Missing and 3 partials ⚠️
internal/proxy/util.go 81.25% 4 Missing and 2 partials ⚠️
pkg/common/common.go 70.58% 3 Missing and 2 partials ⚠️
internal/proxy/task.go 50.00% 2 Missing and 2 partials ⚠️
pkg/util/typeutil/schema.go 71.42% 2 Missing and 2 partials ⚠️
...rnal/querycoordv2/observers/collection_observer.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35416      +/-   ##
==========================================
+ Coverage   72.38%   81.44%   +9.06%     
==========================================
  Files        1234     1234              
  Lines      145723   145876     +153     
==========================================
+ Hits       105475   118806   +13331     
+ Misses      35691    22496   -13195     
- Partials     4557     4574      +17     
Files Coverage Δ
internal/proxy/impl.go 85.99% <100.00%> (ø)
internal/querycoordv2/job/job_load.go 90.35% <100.00%> (+0.08%) ⬆️
internal/querycoordv2/meta/collection_manager.go 87.94% <100.00%> (+0.25%) ⬆️
internal/querycoordv2/server.go 83.43% <100.00%> (+0.03%) ⬆️
internal/querycoordv2/services.go 86.31% <100.00%> (+0.07%) ⬆️
internal/querycoordv2/task/executor.go 79.45% <100.00%> (+1.86%) ⬆️
internal/querycoordv2/task/utils.go 94.85% <100.00%> (+0.03%) ⬆️
internal/querynodev2/segments/collection.go 93.43% <100.00%> (+0.51%) ⬆️
internal/querynodev2/segments/segment_loader.go 77.41% <100.00%> (+0.11%) ⬆️
...rnal/querycoordv2/observers/collection_observer.go 87.43% <75.00%> (-0.77%) ⬇️
... and 5 more

... and 230 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 14, 2024
@congqixia congqixia force-pushed the feat/horizontal_partial_load branch from 66bbbdb to b764099 Compare August 15, 2024 18:27
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 15, 2024
@congqixia congqixia force-pushed the feat/horizontal_partial_load branch from b764099 to 9e2965f Compare August 16, 2024 04:00
@mergify mergify bot removed the ci-passed label Aug 16, 2024
@congqixia congqixia force-pushed the feat/horizontal_partial_load branch from 9e2965f to 2fc6a76 Compare August 19, 2024 09:23
@mergify mergify bot added the ci-passed label Aug 19, 2024
@congqixia congqixia force-pushed the feat/horizontal_partial_load branch from 2fc6a76 to bd8f499 Compare August 19, 2024 16:32
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 19, 2024
@tedxu
Copy link
Contributor

tedxu commented Aug 20, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2fbc628 into milvus-io:master Aug 20, 2024
15 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Aug 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Aug 27, 2024
Cherry-pick from master
pr: #35416
Related to #35415

---------

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the feat/horizontal_partial_load branch September 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants