Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enable/disable mmap for index #29005

Merged
merged 32 commits into from
Dec 21, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 5, 2023

support enable/disable mmap for index, the user could alter the index's mode by AlterIndex method
related: #21866

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/internal-api labels Dec 5, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 5, 2023
Copy link
Contributor

mergify bot commented Dec 5, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <[email protected]>
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Dec 6, 2023
@xiaocai2333
Copy link
Contributor

/lgtm about index meta

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (7d32861) 80.72% compared to head (e852b82) 80.72%.
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #29005    +/-   ##
========================================
  Coverage   80.72%   80.72%            
========================================
  Files         912      912            
  Lines      126296   126606   +310     
========================================
+ Hits       101951   102203   +252     
- Misses      21008    21059    +51     
- Partials     3337     3344     +7     
Files Coverage Δ
internal/datacoord/index_service.go 94.77% <100.00%> (-0.18%) ⬇️
internal/distributed/datacoord/client/client.go 96.18% <100.00%> (-1.15%) ⬇️
internal/distributed/datacoord/service.go 87.70% <100.00%> (+0.10%) ⬆️
internal/proxy/util.go 91.16% <100.00%> (-0.23%) ⬇️
internal/querynodev2/segments/load_index_info.go 69.47% <100.00%> (+1.69%) ⬆️
internal/querynodev2/segments/segment.go 77.00% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 72.69% <100.00%> (ø)
pkg/util/indexparams/index_params.go 87.69% <100.00%> (+0.25%) ⬆️
pkg/util/merr/errors.go 85.71% <ø> (ø)
internal/distributed/proxy/service.go 82.60% <0.00%> (+0.88%) ⬆️
... and 7 more

... and 23 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 11, 2023
Signed-off-by: yah01 <[email protected]>
Signed-off-by: yah01 <[email protected]>
Copy link
Contributor

mergify bot commented Dec 12, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Dec 12, 2023
Copy link
Contributor

mergify bot commented Dec 12, 2023

@yah01 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented Dec 15, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <[email protected]>
Copy link
Contributor

mergify bot commented Dec 15, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 15, 2023

/run-cpu-e2e

1 similar comment
@yah01
Copy link
Member Author

yah01 commented Dec 15, 2023

/run-cpu-e2e

Signed-off-by: yah01 <[email protected]>
Signed-off-by: yah01 <[email protected]>
Copy link
Contributor

mergify bot commented Dec 15, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 15, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 19, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 19, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 20, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 20, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <[email protected]>
Copy link
Contributor

mergify bot commented Dec 20, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 20, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 20, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <[email protected]>
Copy link
Contributor

mergify bot commented Dec 20, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Dec 20, 2023

/run-cpu-e2e

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit a0e1a1e into milvus-io:master Dec 21, 2023
11 of 12 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/internal-api dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants