Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support Truncate collection #26916

Closed

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Sep 7, 2023

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PowderLi
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Sep 7, 2023
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Sep 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

@PowderLi Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@PowderLi PowderLi force-pushed the master-truncate-collection branch from 97a1a70 to f8d927a Compare September 7, 2023 09:42
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Sep 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@PowderLi PowderLi force-pushed the master-truncate-collection branch from f8d927a to 84d5af6 Compare September 7, 2023 12:10
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Attention: 557 lines in your changes are missing coverage. Please review.

Comparison is base (3561586) 80.82% compared to head (c60fd4b) 81.40%.
Report is 12 commits behind head on master.

❗ Current head c60fd4b differs from pull request most recent head 6ea8a76. Consider uploading reports for the commit 6ea8a76 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26916      +/-   ##
==========================================
+ Coverage   80.82%   81.40%   +0.58%     
==========================================
  Files         926      844      -82     
  Lines      127767   118208    -9559     
==========================================
- Hits       103271    96233    -7038     
+ Misses      21145    18739    -2406     
+ Partials     3351     3236     -115     
Files Coverage Δ
internal/datacoord/meta.go 87.17% <100.00%> (-0.58%) ⬇️
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/distributed/proxy/service.go 80.76% <0.00%> (-0.85%) ⬇️
internal/rootcoord/alter_collection_task.go 95.31% <0.00%> (-4.69%) ⬇️
internal/rootcoord/drop_collection_task.go 96.10% <0.00%> (-3.90%) ⬇️
internal/distributed/datacoord/service.go 86.47% <0.00%> (-1.23%) ⬇️
internal/datacoord/index_service.go 94.27% <0.00%> (-0.47%) ⬇️
internal/proxy/task.go 85.57% <0.00%> (+0.08%) ⬆️
internal/distributed/rootcoord/service.go 78.21% <0.00%> (-1.35%) ⬇️
internal/util/mock/grpc_rootcoord_client.go 79.48% <0.00%> (-4.30%) ⬇️
... and 9 more

... and 450 files with indirect coverage changes

@congqixia
Copy link
Contributor

congqixia commented Sep 8, 2023

@PowderLi
I was wondering that is there any design doc we could use for reviewing this feature PR? thanks in advance

@stale
Copy link

stale bot commented Oct 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Oct 8, 2023
@congqixia
Copy link
Contributor

keep it
/reopen

@stale stale bot removed the stale indicates no udpates for 30 days label Oct 8, 2023
Copy link

stale bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 7, 2023
@PowderLi PowderLi force-pushed the master-truncate-collection branch from 84d5af6 to fbf3bdf Compare November 14, 2023 09:37
@stale stale bot removed the stale indicates no udpates for 30 days label Nov 14, 2023
Copy link
Contributor

mergify bot commented Nov 14, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 14, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2023

@PowderLi

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • enhance: for improvements to existing functionality.
  • fix: for bug fixes.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, enhance, or fix.

Example:

feat: Enhance search functionality within the user interface

Please review and update your PR to comply with these guidelines.

@PowderLi PowderLi force-pushed the master-truncate-collection branch from fbf3bdf to c60fd4b Compare November 16, 2023 09:53
Copy link
Contributor

mergify bot commented Nov 16, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Jan 6, 2024

/run-cpu-e2e

@PowderLi PowderLi force-pushed the master-truncate-collection branch from d63200e to dff199e Compare January 6, 2024 08:12
Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@PowderLi PowderLi force-pushed the master-truncate-collection branch from dff199e to 6ea8a76 Compare January 6, 2024 10:02
Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 6, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 6, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 6, 2024

@PowderLi

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

stale bot commented Mar 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Mar 7, 2024
@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Mar 7, 2024
Copy link
Contributor

mergify bot commented Mar 7, 2024

@PowderLi Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@stale stale bot closed this Mar 14, 2024
@JackLCL JackLCL reopened this Mar 20, 2024
@stale stale bot removed the stale indicates no udpates for 30 days label Mar 20, 2024
@JackLCL
Copy link
Contributor

JackLCL commented Mar 20, 2024

Any updates?

Signed-off-by: PowderLi <[email protected]>
@PowderLi PowderLi force-pushed the master-truncate-collection branch from 6ea8a76 to 9bfc32f Compare March 22, 2024 22:39
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Mar 22, 2024
Copy link
Contributor

mergify bot commented Mar 22, 2024

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 22, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Apr 22, 2024
@stale stale bot closed this May 1, 2024
@PowderLi
Copy link
Contributor Author

/reopen

@sre-ci-robot
Copy link
Contributor

@PowderLi: Failed to re-open PR: state cannot be changed. The master-truncate-collection branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. do-not-merge/invalid-pr-format size/XXL Denotes a PR that changes 1000+ lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants