-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable etcd auto compaction in Milvus's Ubuntu package #16723
Enable etcd auto compaction in Milvus's Ubuntu package #16723
Conversation
Welcome @schuberttobias! It looks like this is your first PR to milvus-io/milvus 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: schuberttobias The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@schuberttobias Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@schuberttobias, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details. |
@@ -27,4 +27,4 @@ StandardError=inherit | |||
Restart=always | |||
|
|||
# Start main service | |||
ExecStart=/usr/bin/milvus-etcd --data-dir /etc/milvus/etcd-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LoveEachDay: What is the correct value for --data-dir
?
In the master
branch it is --data-dir /etc/milvus/etcd-data
.
But when I apt-get install milvus==2.0.2-1
the content of /etc/systemd/system/milvus-etcd.service
is different: --data-dir /var/lib/milvus/etcd-data
.
/var/lib/milvus/etcd-data/
exists and holds files, /etc/milvus/etcd-data
does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change the default data directory for milvus 2.0.2.
/cc @Bennu-Li
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ubuntu the default data directory for etcd is /var/lib/milvus/ectd-data
, and for centos related the default directory for etcd is /etc/milvus/etcd-data
.
And for now we don't put the service config for ubuntu into milvus repo.
3c89a5f
to
5d90211
Compare
5d90211
to
7ed3616
Compare
I think I've applied all changes as requested and explained by your CI. Do you have a branch name convention? I did not find one and emulated @xiaofan-luan 's style |
Codecov Report
@@ Coverage Diff @@
## master #16723 +/- ##
==========================================
- Coverage 81.16% 80.72% -0.44%
==========================================
Files 457 440 -17
Lines 72871 69524 -3347
==========================================
- Hits 59144 56122 -3022
+ Misses 10988 10731 -257
+ Partials 2739 2671 -68
|
/lgtm |
@schuberttobias We've update the data directory for etcd. Could you rebase your code? |
Use same values as in docker-compose.yml (see https://github.com/milvus-io/milvus/blob/fce8f6cfabb44307a9e640778630c3d15bfc2822/deployments/docker/standalone/docker-compose.yml#L7-L9) Signed-off-by: Tobias Schubert <[email protected]>
7ed3616
to
f84a684
Compare
New changes are detected. LGTM label has been removed. |
@LoveEachDay Yes, I rebased onto 1cabaa1. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Issue: #16511
@smeikalr: FYI, I've set up this PR based on our own fix.