Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Partition-level rate limiting is not working #37685

Closed
1 task done
bigsheeper opened this issue Nov 14, 2024 · 5 comments
Closed
1 task done

[Bug]: Partition-level rate limiting is not working #37685

bigsheeper opened this issue Nov 14, 2024 · 5 comments
Assignees
@SimFG @bigsheeper
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. stale indicates no udpates for 30 days

Comments

@bigsheeper
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master&2.4
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

If the user does not specify a partitionName (which is allowed, such as when inserts default to the "default" partition without specifying partitionName), the partition limiter check is bypassed, resulting in partition-level rate limiting being not working.
Rb7O7lOKOn

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@bigsheeper bigsheeper added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 14, 2024
@bigsheeper
Copy link
Contributor Author

/assign @SimFG
/unassign @yanliang567

@sre-ci-robot sre-ci-robot assigned SimFG and unassigned yanliang567 Nov 14, 2024
@bigsheeper
Copy link
Contributor Author

/assign

@SimFG SimFG mentioned this issue Nov 25, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 27, 2024
@SimFG
fix: use the default partition for the limit quota when the request p…
302650a 
…artition name is empty (#38005)

- issue: #37685

Signed-off-by: SimFG <[email protected]>
@stale Stale
Copy link

stale bot commented Dec 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 20, 2024
@SimFG
Copy link
Contributor

SimFG commented Dec 20, 2024

/close

@sre-ci-robot
Copy link
Contributor

@SimFG: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimFG SimFG

@bigsheeper bigsheeper

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SimFG @bigsheeper @sre-ci-robot @yanliang567