Support connection pool #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ruiyi.jiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 95.15% 96.39% +1.24%
==========================================
Files 39 39
Lines 1837 1859 +22
Branches 436 474 +38
==========================================
+ Hits 1748 1792 +44
+ Misses 86 61 -25
- Partials 3 6 +3 ☔ View full report in Codecov by Sentry. |
nameczz
requested changes
Dec 11, 2023
Comment on lines
7
to
+12
| export enum CONNECT_STATUS { | ||
| NOT_CONNECTED, | ||
| CONNECTING, | ||
| CONNECTED, | ||
| CONNECTING = 0, // GRPC channel state connecting | ||
| CONNECTED = 1, // GRPC channel state ready | ||
| UNIMPLEMENTED, | ||
| SHUTDOWN = 5, // GRPC channel state shutdown |
There was a problem hiding this comment.
Should we set NOT_CONNECTED and UNIMPLEMENTED more clearly？
nameczz
approved these changes
Dec 12, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nameczz, shanghaikid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, according to the https://grpc.io/docs/guides/performance/, I add a connection pool for the node sdk, it will have a breaking change for the
closeConnectionfunction. it should close until all channels are cleaned in the pool and return the connect status. All other methods should be compatible with old version.User now is able to set up the pool
minandmaxin theClientConfigobject. by default it is 10 and 2.