Milvus Client V2 #746
Merged
Milvus Client V2 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @nianliuu! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉 |
yhmo
reviewed
Jan 23, 2024
| */ | ||
| public void connect(ConnectConfig connectConfig){ | ||
| this.connectConfig = connectConfig; | ||
| channel = clientUtils.getChannel(connectConfig); |
There was a problem hiding this comment.
If the "channel" is already connected, better to shutdown it before this line.
There was a problem hiding this comment.
ok, will update
if(this.channel != null){
this.channel.shutdownNow();
}
…or V2 API. Signed-off-by: Nian Liu <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nianliuu, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nianliuu
added a commit
that referenced
this pull request
Jan 26, 2024
…or V2 API. (#746) Signed-off-by: Nian Liu <[email protected]> (cherry picked from commit b9e4c05)
nianliuu
added a commit
that referenced
this pull request
Jan 26, 2024
…or V2 API. (#746) Signed-off-by: Nian Liu <[email protected]> (cherry picked from commit b9e4c05)
nianliuu
added a commit
that referenced
this pull request
Feb 5, 2024
…or V2 API. (#746) Nian Liu* 1/26/24, 5:12 PM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have 5 different milvus SDK: python, java, node, go, restful. With the evolve of milvus, different api have different api format and usage. It's becoming harder to maintain for owner and harder to use for user. Based on this, we reformate unified all 5 SDKs. Providing this V2 API.
Code Change
Test