Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional db for grant/revoke v2 #852

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

shaoting-huang
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 4, 2024
Signed-off-by: shaoting-huang <[email protected]>
@mergify mergify bot added the ci-passed auto merge needed label label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d5a335b) to head (f743f07).
Report is 60 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #852       +/-   ##
=========================================
- Coverage   72.11%      0   -72.12%     
=========================================
  Files          51      0       -51     
  Lines        4794      0     -4794     
=========================================
- Hits         3457      0     -3457     
+ Misses       1213      0     -1213     
+ Partials      124      0      -124     

see 51 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Dec 9, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Dec 9, 2024
@sre-ci-robot sre-ci-robot merged commit 48dfc36 into milvus-io:master Dec 9, 2024
7 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 10, 2024
cherry-pick from master:
#852
issue: milvus-io/milvus#37031

Signed-off-by: shaoting-huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants