Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard outputfield expansion logic back #604

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

congqixia
Copy link
Contributor

See also #596
/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Oct 24, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby October 24, 2023 11:43
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from yah01 October 24, 2023 11:43
@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #604 (aab0ea4) into master (647cbab) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   82.85%   82.93%   +0.07%     
==========================================
  Files          40       40              
  Lines        3640     3656      +16     
==========================================
+ Hits         3016     3032      +16     
  Misses        512      512              
  Partials      112      112              
Files Coverage Δ
client/data.go 70.39% <100.00%> (+1.38%) ⬆️

@congqixia congqixia force-pushed the fix_outputfield_wildcard branch from 2d1d6e7 to aab0ea4 Compare October 24, 2023 15:19
@mergify mergify bot added the ci-passed auto merge needed label label Oct 24, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 25, 2023
@sre-ci-robot sre-ci-robot merged commit 8a5f679 into milvus-io:master Oct 25, 2023
6 checks passed
ThreadDao pushed a commit to ThreadDao/milvus-sdk-go that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants