Add API HasRawData() for get vector #828
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cydrain Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
cydrain
force-pushed
the
caiyd_add_has_raw_data
branch
from
76684da to
7a70fdf
Compare
|
/kind improvement |
src/index/diskann/diskann.cc
Outdated
| @@ -62,6 +62,15 @@ class DiskANNIndexNode : public IndexNode { | |||
| expected<DataSetPtr, Status> | |||
| GetVectorByIds(const DataSet& dataset, const Config& cfg) const override; | |||
|
|
|||
| bool | |||
| HasRawData(const std::string& metric_type) const override { | |||
| if (metric_type == metric::L2) { | |||
| if constexpr (std::is_same<faiss::IndexBinaryIVF, T>::value) { | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
If none of the above conditions are met, will there be a return value?
There was a problem hiding this comment.
that will not happen
| if constexpr (std::is_same_v<detail::raft_ivf_pq_index, T>) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
If none of the above conditions are met, will there be a return value?
There was a problem hiding this comment.
that will not happen
cydrain
force-pushed
the
caiyd_add_has_raw_data
branch
from
7a70fdf to
2ffc379
Compare
Signed-off-by: Yudong Cai <[email protected]>
cydrain
force-pushed
the
caiyd_add_has_raw_data
branch
from
7c2ede8 to
fc1e17b
Compare
|
/lgtm |
No description provided.