Transfer branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aiting / Yielding (#4364) * Changed logic to actually wait on profile completion, updated test functions to allow code to await dynamically generated requests * Fixed another instance of invalid AJAX request wait for env-info sync
…llow a transition to dashboard (#4384) * Fixes: - Registration polling added to check for profile before running env-info - Nits tackled - Removed an unnecessary wait * Final Changes: - Tested poll mechanism - Added missing API iron-ajax element - Updated docs - Increased profile wait timeout to 20s with a wait-interval of 500ms * Tests fixed: - Delay per check now only 300ms - Removed unnecessary wait after API - Tests fixed - Added new test for DB inconsistency * Test updates: - Made all tests pass - Switched to Jasmine.clock() - Tests now correctly handle jasmine tick relevant waiting - Added a negative test, when consisitency in DB happens after 20s
…n-Identity Clusters (#4425) * Fixes issue #4415 by giving /exists a hasWorkgroup condition for non-identity cluster * Fixed tests
Change-Id: I9f4b4871a5d02a53230abb836787f665dd8e3998 Signed-off-by: Henry Wang <[email protected]> Jira: ENTOS-1322
2.Fix chromium@edge version cannot start bug Change-Id: I037201cd64b174710d0e637a633ba28f2270f77b Signed-off-by: Henry Wang <[email protected]> Jira: ENTOS-1310
* 4077: Add e2e Profiles test * Update to use util.maybe_activate_service_account()
* Show namespace selector when choosing pipelines * Remove no longer needed test
* Add metadata field to PodDefaults This copies labels and annotations from the PodDefault's metadata field to pods. This closes #4502 * Use dedicated fields for annotations and labels
* Add kubeflow labels into namespace by profile-controller * Make sure label value keep same as required * Add ut test
…cluster (#4568)
* Get rid of the PVC used to pass the image digest file between the build
and update manifests step
* Creating a PVC just creates operational complexity
* We combine the build and update manifests step into one task. We can
then use /workspace (a pod volume) to pass data like the image digest
file between the steps
* Update pipelineRun to work with version 0.9 of Tekton
* Field serviceAccount has been renamed serviceAccountName
* TaskRun no longer supports outputImageDir so we remove it; we will
have to use Tekton to pass the image digest file
* Remove the namespace.yaml and secrets.yaml from the kustomize package
* The secrets should be created out of band and not checked in
* So the behavior should be to deploy the kustomize package in a namespace
that already exists with the appropriate secrets
* Checking in secrets is confusing
* If we check in dummy secrets then users will get confused about
whether the secrets are valid or not
* Furthermore, the file secrets.yaml is an invitation to end up checking
the secrets into source control.
* Configure some values to use gcr.io/kubeflow-images-public
* Disable ISTIO sidecar in the pipelines
* For kaniko we don't need the secret to be named a certain way we just
need to set GOOGLE_APPLICATION_CREDENTIALS to point to the correct value
* We change kaniko to use the user-gcp-sa secret that Kubeflow creates
* We shouldn't need an image pull secret since kubeflow-images-public is public
* GOOGLE_APPLICATION_CREDENTIALS should be used for pushing images
* Change the name of the secret containing ssh credentials for kubeflow-bot
to kubeflow-bot-github-ssh
* rebuild-manifests.sh should use /workspace to get the image digest
rather than the PVC.
* Simplify rebuild-manifests.ssh
* Tekton will mount the .ssh information in /tekton/home/.ssh
so we just need to create a symbolic link to /root/.ssh
* The image digest file should be fetched from /workspace and not some PVC.
* Set GITHUB_TOKEN environment variable using secrets so that we don't
need to use kubectl get to fetch it
* We need to make the clone of kubeflow/manifests a non-shallow clone
before we can push changes to the remote repo
* I was able to successfully run the profile controller workflow and create a
PR
kubeflow/manifests#669
Next steps:
* This PR only updated the profile controller
* We need to refactor how the PipelineRun's are laid out
* I think we may want the PipelineRun's to be separate from the reused
resurces like Task
* rebuil-manifests.sh should only regenerate tests for changed files
* The created PRs don't satisfy the Kubeflow CLA check.
Related to: kubeflow/testing#450
* Delete all the Tekton pipelines and scripts for continuous delivery of Kubeflow applications because they are moving into kubeflow/testing * kubeflow/testing#551 is the PR moving the code into kubeflow/testing Related to: kubeflow/testing#544 redo how we use kustomize and Tekton to parameterize the pipelines
…4625) * generate license for kfam image; switch to a distroless base image * use distroless base
add hashicorp/golang-lru source code to kfam image
* Defaulting logic added for Namespace selector, also validates invalid namespaces * Reduce the owned scan on namespaces when validity on namespace is good Remove an extra call to validate Removed extra line * Fixed presubmit tests * Removed extra debugging statement * Fixed comments in the code to reflect the function definition
Before we used the annotations/labels from PodDefaults's embedded ObjectMeta instead of the correct Annotations/Labels field of the PodDefaultSpec. This also adds tests for the (SafeTo)ApplyPodDefaultsOnPod function to that uncovered the issue.
* kfam: prometheus monitoring integration * address review comments
* Sync iframe href on hashchange too * Update iframe-container.js
…ntraldashboard-angular/frontend (#7217) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nents/centraldashboard-angular/backend (#7361) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.1 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nents/centraldashboard-angular/frontend (#7362) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.1 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The ISTIO_INGRESS_GATEWAY_PRINCIPAL and NOTEBOOK_CONTROLLER_PRINCIPAL had an extra ) at the end of the value. Fixes #7374
…ldashboard-angular/backend (#6773) Bumps [yargs-parser](https://github.com/yargs/yargs-parser) to 20.2.9 and updates ancestor dependency [concurrently](https://github.com/open-cli-tools/concurrently). These dependencies need to be updated together. Updates `yargs-parser` from 11.1.1 to 20.2.9 - [Release notes](https://github.com/yargs/yargs-parser/releases) - [Changelog](https://github.com/yargs/yargs-parser/blob/main/CHANGELOG.md) - [Commits](yargs/yargs-parser@v11.1.1...yargs-parser-v20.2.9) Updates `concurrently` from 4.1.2 to 7.6.0 - [Release notes](https://github.com/open-cli-tools/concurrently/releases) - [Commits](open-cli-tools/concurrently@v4.1.2...v7.6.0) --- updated-dependencies: - dependency-name: yargs-parser dependency-type: indirect - dependency-name: concurrently dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oard-angular/frontend (#7117) Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `engine.io` from 6.2.1 to 6.4.2 - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md) - [Commits](socketio/engine.io@6.2.1...6.4.2) Updates `socket.io` from 4.5.4 to 4.6.1 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io@4.5.4...4.6.1) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect - dependency-name: socket.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rs screen (#7188) (#7242)
…ntraldashboard (#7324) Bumps [fsevents](https://github.com/fsevents/fsevents) from 1.2.9 to 1.2.13. - [Release notes](https://github.com/fsevents/fsevents/releases) - [Commits](fsevents/fsevents@v1.2.9...v1.2.13) --- updated-dependencies: - dependency-name: fsevents dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3344 to 0.17.0 in /components/access-management (#7327) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20200625001655-4c5254603344 to 0.17.0. - [Commits](https://github.com/golang/net/commits/v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ents/centraldashboard (#7360) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.6.2 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update central-dashboard to NodeJS 16 Signed-off-by: Mathew Wicks <[email protected]> * update `@kubernetes/client-node` to `0.19.0` Signed-off-by: Mathew Wicks <[email protected]> * update `express` to `4.19.2` Signed-off-by: Mathew Wicks <[email protected]> * update `@grpc/grpc-js` to `1.10.8` Signed-off-by: Mathew Wicks <[email protected]> * update `@types/serve-static` to `1.15.5` Signed-off-by: Mathew Wicks <[email protected]> * update `typescript` to `4.9.5` Signed-off-by: Mathew Wicks <[email protected]> * fix TS2538 error in metrics query interval Signed-off-by: Mathew Wicks <[email protected]> * update `webpack` to `4.47.0` Signed-off-by: Mathew Wicks <[email protected]> * fix tests (update kustomize + others) Signed-off-by: Mathew Wicks <[email protected]> * remove unnecessary `npm rebuild` Signed-off-by: Mathew Wicks <[email protected]> * use `tini` as entrypoint Signed-off-by: Mathew Wicks <[email protected]> * remove `script-ext-html-webpack-plugin` Signed-off-by: Mathew Wicks <[email protected]> * fix namespace selector for iframes in local dev Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Mathew Wicks <[email protected]>
* (feat) Added possibility to parse namespaces in externalLinks * small changes Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Hyeonki Hong <[email protected]>
* profiles: Pin the env-test version Signed-off-by: Kimonas Sotirchos <[email protected]> * profiles: Add generated files from make test Signed-off-by: Kimonas Sotirchos <[email protected]> --------- Signed-off-by: Kimonas Sotirchos <[email protected]>
Signed-off-by: mishraprafful <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
* Expose metrics with prom-client Expose default and custom metrics with prom-client [1]. Custom metrics: - rest_http_request_duration_seconds (Histogram) - response time - rest_http_request_total (Counter) - response count - app_info (Gauge) - app information: app name and version --- [1]: https://www.npmjs.com/package/prom-client Signed-off-by: Robert Gildein <[email protected]> * add simple test and apply suggestions Signed-off-by: Robert Gildein <[email protected]> * apply suggestions Signed-off-by: Robert Gildein <[email protected]> --------- Signed-off-by: Robert Gildein <[email protected]>
* using GET instead of POST method to handle logout Signed-off-by: Tarek Abouzeid <[email protected]> * adding logoutURL template to href Signed-off-by: Tarek Abouzeid <[email protected]> * refactor logout Signed-off-by: Tarek Abouzeid <[email protected]> --------- Signed-off-by: Tarek Abouzeid <[email protected]>
* upgrade node from 12 to 16 Signed-off-by: tariq-hasan <[email protected]> * replace cypress with playwright for e2e tests in jupyter Signed-off-by: tariq-hasan <[email protected]> * update base image for node Signed-off-by: tariq-hasan <[email protected]> * update build scripts for tensorboard Signed-off-by: tariq-hasan <[email protected]> * update build scripts for jupyter Signed-off-by: tariq-hasan <[email protected]> --------- Signed-off-by: tariq-hasan <[email protected]>
Signed-off-by: Kimonas Sotirchos <[email protected]>
…669) * chore: Add securitycontext for PSS PoC Signed-off-by: biswassri <[email protected]> * mathew: explicitly use non-root base images and set user/group in Dockerfile Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: biswassri <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
milinddethe15
pushed a commit
that referenced
this pull request
Feb 27, 2025
Create initial OWNERS file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist