update label #3
Closed
update label #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 30, 2017 13:13
dildick
deleted the
from-CMSSW_9_1_X_2017-04-29-1100-ME0-realistic-digi-updates
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dildick , the bkg params are fixed and obsolete code is removed. Also i crosschecked the other background config parameters. I have changed the safety factor for the new beam pipe from 2 to 1, since the effect is already included in the blg model. Also the reference lumi parameter is taken now to configuration - previously it was hard-coded.
I am not sure this the correct place to make this PR, but I am not able to revert the base-fork and head-fork.