Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scala Native JUnit plugin #1259

Merged

Conversation

armanbilge
Copy link

Backport of typelevel/shapeless-3#88 (comment).

I think it would be helpful to get a release with this fix, I was running into some conflicting dependency problems downstream. Thanks!

@milessabin
Copy link
Owner

Isn't this just a change in test? Why does that need a new release?

@joroKr21
Copy link
Collaborator

joroKr21 commented Jul 6, 2022

Also we are releasing from series/2.3 branch - the main was supposed to be Scala 2/3 cross compatible but we never reached that state.

@armanbilge armanbilge force-pushed the fix/native-junit-plugin branch from 298a609 to 6030681 Compare July 6, 2022 13:09
@armanbilge armanbilge changed the base branch from main to series/2.3 July 6, 2022 13:09
@armanbilge armanbilge closed this Jul 6, 2022
@armanbilge armanbilge reopened this Jul 6, 2022
@armanbilge
Copy link
Author

@joroKr21 woops, thanks, rebased :)

@milessabin good question. The reason is because it changes how your POM is generated.

Of course it's not Shapeless' fault, but there were two issues with Scala Native affecting POM generation that have been fixed since shapeless last released:

Here's the current POM.
https://repo1.maven.org/maven2/com/chuusai/shapeless_native0.4_2.13/2.3.9/shapeless_native0.4_2.13-2.3.9.pom

And here's what pops out after this change:

    <dependencies>
        <dependency>
            <groupId>org.scala-lang</groupId>
            <artifactId>scala-compiler</artifactId>
            <version>2.13.8</version>
            <scope>provided</scope>
            <exclusions>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>nativelib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>clib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>posixlib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>windowslib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>javalib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>auxlib_native0.4_3</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>org.scala-lang</groupId>
            <artifactId>scala-library</artifactId>
            <version>2.13.8</version>
            <exclusions>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>nativelib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>clib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>posixlib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>windowslib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>javalib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>auxlib_native0.4_3</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>org.scala-native</groupId>
            <artifactId>test-interface_native0.4_2.13</artifactId>
            <version>0.4.5</version>
            <scope>test</scope>
            <exclusions>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>nativelib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>clib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>posixlib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>windowslib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>javalib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>auxlib_native0.4_3</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>org.scala-native</groupId>
            <artifactId>scalalib_native0.4_2.13</artifactId>
            <version>0.4.5</version>
            <exclusions>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>nativelib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>clib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>posixlib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>windowslib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>javalib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>auxlib_native0.4_3</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>org.scala-native</groupId>
            <artifactId>junit-runtime_native0.4_2.13</artifactId>
            <version>0.4.5</version>
            <scope>test</scope>
            <exclusions>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>nativelib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>clib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>posixlib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>windowslib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>javalib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>auxlib_native0.4_3</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>org.scala-lang</groupId>
            <artifactId>scala-reflect</artifactId>
            <version>2.13.8</version>
            <scope>provided</scope>
            <exclusions>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>nativelib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>clib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>posixlib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>windowslib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>javalib_native0.4_3</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>org.scala-native</groupId>
                    <artifactId>auxlib_native0.4_3</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
    </dependencies>

@milessabin milessabin merged commit 2a8df00 into milessabin:series/2.3 Jul 6, 2022
@milessabin
Copy link
Owner

OK, merged.

@armanbilge bearing in mind that shapeless 2 is epoch.major.minor ... is this a minor or a major version bump for the release?

@armanbilge
Copy link
Author

This seems fine as a minor. It's essentially just fixing metadata.

@armanbilge
Copy link
Author

For prior art, Seb made a similar release as patch:
https://github.com/portable-scala/portable-scala-reflect/releases/tag/v1.1.2

@armanbilge
Copy link
Author

@milessabin polite bump on a release for this? :)

@joroKr21
Copy link
Collaborator

joroKr21 commented Sep 2, 2022

Oh I didn't realise we needed a release 👍

@joroKr21
Copy link
Collaborator

joroKr21 commented Sep 2, 2022

Any idea why #1267 failed? 🤔

@joroKr21
Copy link
Collaborator

I did some cleanup and finally released 🚀

@armanbilge
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants