-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Scala Native JUnit plugin #1259
Use Scala Native JUnit plugin #1259
Conversation
Isn't this just a change in test? Why does that need a new release? |
Also we are releasing from |
298a609
to
6030681
Compare
@joroKr21 woops, thanks, rebased :) @milessabin good question. The reason is because it changes how your POM is generated. Of course it's not Shapeless' fault, but there were two issues with Scala Native affecting POM generation that have been fixed since shapeless last released:
Here's the current POM. And here's what pops out after this change: <dependencies>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-compiler</artifactId>
<version>2.13.8</version>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>nativelib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>clib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>posixlib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>windowslib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>javalib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>auxlib_native0.4_3</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
<version>2.13.8</version>
<exclusions>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>nativelib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>clib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>posixlib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>windowslib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>javalib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>auxlib_native0.4_3</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.scala-native</groupId>
<artifactId>test-interface_native0.4_2.13</artifactId>
<version>0.4.5</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>nativelib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>clib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>posixlib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>windowslib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>javalib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>auxlib_native0.4_3</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.scala-native</groupId>
<artifactId>scalalib_native0.4_2.13</artifactId>
<version>0.4.5</version>
<exclusions>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>nativelib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>clib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>posixlib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>windowslib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>javalib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>auxlib_native0.4_3</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.scala-native</groupId>
<artifactId>junit-runtime_native0.4_2.13</artifactId>
<version>0.4.5</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>nativelib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>clib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>posixlib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>windowslib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>javalib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>auxlib_native0.4_3</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-reflect</artifactId>
<version>2.13.8</version>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>nativelib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>clib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>posixlib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>windowslib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>javalib_native0.4_3</artifactId>
</exclusion>
<exclusion>
<groupId>org.scala-native</groupId>
<artifactId>auxlib_native0.4_3</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies> |
OK, merged. @armanbilge bearing in mind that shapeless 2 is |
This seems fine as a minor. It's essentially just fixing metadata. |
For prior art, Seb made a similar release as patch: |
@milessabin polite bump on a release for this? :) |
Oh I didn't realise we needed a release 👍 |
Any idea why #1267 failed? 🤔 |
I did some cleanup and finally released 🚀 |
Thanks! |
Backport of typelevel/shapeless-3#88 (comment).
I think it would be helpful to get a release with this fix, I was running into some conflicting dependency problems downstream. Thanks!