Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Base.Ordering for heap, and other performance changes #13

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

milesfrain
Copy link
Owner

No description provided.

@milesfrain milesfrain force-pushed the ord3 branch 2 times, most recently from beae028 to 1bc5464 Compare October 25, 2019 19:21
@codecov-io
Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #13 into master will decrease coverage by 0.15%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   87.82%   87.67%   -0.16%     
==========================================
  Files          32       32              
  Lines        2086     2052      -34     
==========================================
- Hits         1832     1799      -33     
+ Misses        254      253       -1
Impacted Files Coverage Δ
src/heaps.jl 100% <100%> (+8%) ⬆️
src/heaps/minmax_heap.jl 91.86% <100%> (+0.09%) ⬆️
src/heaps/arrays_as_heaps.jl 89.28% <100%> (+3.07%) ⬆️
src/heaps/mutable_binary_heap.jl 88.57% <100%> (ø) ⬆️
src/heaps/binary_heap.jl 88.88% <83.33%> (-11.12%) ⬇️
src/sparse_int_set.jl 95.78% <0%> (-0.13%) ⬇️
src/priorityqueue.jl 96.89% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452caf8...5bf4b0c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants