Check vaccinations in ISIN #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaspavlin
requested review from
tomaskourim,
misslecter,
marazt and
LukasForst
tomaskourim
requested changes
Jun 17, 2021
| @@ -82,7 +82,8 @@ | |||
| <app-patient-data-item> | |||
| <mat-label>Validováno v ISIN:</mat-label> | |||
| <mat-label> | |||
| <app-chip [value]="!!patientData.isinId"></app-chip> | |||
| <app-chip [value]="!!patientData.isinId && !!patientData.isinReady" | |||
There was a problem hiding this comment.
Tady podle me ma byt OR. Pokud nemame id nebo neni ready, chceme ukazovat ze Validovano v ISIN: NE
There was a problem hiding this comment.
!! je negace negace. Když máme isin id && je to ready, ukazujeme ANO
There was a problem hiding this comment.
A to jako Angular vyzaduje, kdyz chci pracovat s nejakou boolean, abych udelal negaci negace? patientData.isinReady nefunguje, jo?
There was a problem hiding this comment.
Ono to může být i null a tímhle se to převede na false
There was a problem hiding this comment.
aha, ok. To jsou triky tedy...
tomaskourim
requested changes
Jun 17, 2021
tomaskourim
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Na FE po najetí na Ano/Ne u Validováno v ISIN zobrazím tooltip s dalším infem.
Otestoval jsem provoláváním api, v tom testovacím prostředí to vždy našlo nějaké proběhlé očkování.
Closes #294