Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIK-373] Create cutscenes #169

Merged
merged 42 commits into from
Nov 29, 2024
Merged

[MIK-373] Create cutscenes #169

merged 42 commits into from
Nov 29, 2024

Conversation

Lredigonda
Copy link
Contributor

@Lredigonda Lredigonda commented Oct 16, 2024

Screenshot 2024-11-13 at 2 47 54 PM

@miku448
Copy link
Contributor

miku448 commented Oct 30, 2024

can i remove the character in the cutscene and use only background? I think that is how it's going to be used, without characters at all

@Lredigonda Lredigonda requested a review from miku448 November 14, 2024 03:55
@miku448
Copy link
Contributor

miku448 commented Nov 16, 2024

A couple of issues:

  • let's add the transparency to indicate non-selected components of each part (for example, the character 1 field should look like the character 2 field). If the music is not selected or text is not added it should be shown transparent too
  • if I open the second character and haven't selected it, the modal shows the first character
  • does selecting the emotion/outfit of the character in the carousel affects the cutscene?
  • do NOT add a default text to each scene part, empty text should be fine
  • "Create" button (in cutscene) should be "Add section'
  • For the text parts, we should redesign it a bit to be lines, with a dropdown for (dialogue/description) that affects the text color of the text inside the text input, which should be single line with a button at the end to delete it. the button to add more should be at the end of the line

@miku448 miku448 merged commit 0b48e02 into master Nov 29, 2024
6 checks passed
@miku448 miku448 deleted the mik-373-create-cutscenes branch November 29, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants