fix(manager): wait after Scylla config change to let SM pick up the c… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikliapko
pushed a commit
that referenced
this pull request
Dec 6, 2024
…rom 3 to 4 As observed in a couple of new gemini runs [#6](https://argus.scylladb.com/tests/scylla-cluster-tests/f0c504cb-4bf5-47d4-a6bb-f0a102ec7fe4) [scylladb#7](https://argus.scylladb.com/tests/scylla-cluster-tests/26276989-e33c-40f1-9e94-788a4d824344) [#4](https://argus.scylladb.com/tests/scylla-cluster-tests/193e537e-e025-4857-86db-2156cd870fc3) [#2] https://argus.scylladb.com/tests/scylla-cluster-tests/41d1290a-1998-4bf4-9d15-4b21ad98cff9 Gemini's failures are caused by not having enough nodes in the test DB when cluster in run with Tablets, and by that we cannot establish quorum. This PR increases the number of nodes in the test DB to 4 in all relevant cases with nemesis. Signed-off-by: Dusan Malusev <[email protected]>
mikliapko
added a commit
that referenced
this pull request
Dec 20, 2024
Error message Manager returns for enospc scenario has been changed to more generic one (#1). So, it doesn't make much sense to verify it. Moreover, there is a plan to fix check free disk space behaviour and the whole test will probably require rework to be done (#2). refs: #1 - scylladb/scylla-manager#4087 #2 - scylladb/scylla-manager#4184
mikliapko
added a commit
that referenced
this pull request
Dec 30, 2024
According to comment (1), set ks strategy and rf is not needed if restoring the schema within one DC. It should be brought back after implementation of (2) which will unblock schema restore into a different DC. For now, it's possible to restore schema only within one DC. Refs: #1: scylladb/scylla-manager#4041 issuecomment-2565489699 #2: scylladb/scylla-manager#4049
mikliapko
added a commit
that referenced
this pull request
Jan 2, 2025
According to comment (1), set ks strategy and rf is not needed if restoring the schema within one DC. It should be brought back after implementation of (2) which will unblock schema restore into a different DC. For now, it's possible to restore schema only within one DC. Refs: #1: scylladb/scylla-manager#4041 issuecomment-2565489699 #2: scylladb/scylla-manager#4049
mikliapko
added a commit
that referenced
this pull request
Jan 8, 2025
Error message Manager returns for enospc scenario has been changed to more generic one (#1). So, it doesn't make much sense to verify it. Moreover, there is a plan to fix check free disk space behaviour and the whole test will probably require rework to be done (#2). refs: #1 - scylladb/scylla-manager#4087 #2 - scylladb/scylla-manager#4184
mikliapko
added a commit
that referenced
this pull request
Jan 8, 2025
According to comment (1), set ks strategy and rf is not needed if restoring the schema within one DC. It should be brought back after implementation of (2) which will unblock schema restore into a different DC. For now, it's possible to restore schema only within one DC. Refs: #1: scylladb/scylla-manager#4041 issuecomment-2565489699 #2: scylladb/scylla-manager#4049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.