Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override for finding record during session creation #33

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

avinoth
Copy link
Contributor

@avinoth avinoth commented Dec 29, 2018

  • Allow users to custom define the find method for the resource by given email

* Allow users to custom define the find method for the resource by given email
@mikker
Copy link
Owner

mikker commented Dec 29, 2018

Looks good to me 👍

Can you add a test case and a note to the Readme?

Thank you!

@avinoth
Copy link
Contributor Author

avinoth commented Jan 3, 2019

@mikker Done 👍

Copy link
Owner

@mikker mikker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! A few comments, otherwise perfect 👍

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/controllers/passwordless/sessions_controller_test.rb Outdated Show resolved Hide resolved
@mikker
Copy link
Owner

mikker commented Jan 4, 2019

👌

@mikker mikker merged commit f0f3a9d into mikker:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants