Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller/keyboard navigation support for <select> #566

Merged
merged 6 commits into from
Oct 31, 2024
Merged

controller/keyboard navigation support for <select> #566

merged 6 commits into from
Oct 31, 2024

Commits on Oct 30, 2024

  1. fix a couple quirks with <select>: 

    - selectbox now scrolls when nav is being used
- selectbox ensures that the selected option is scrolled into view, anchored to the top
- "escape" can be used to cancel selection
    @Paril @mikke89
    Paril authored and mikke89 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    64dc124 View commit details
    Browse the repository at this point in the history

  2. remove C++17 assignment

    @Paril @mikke89
    Paril authored and mikke89 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b86a673 View commit details
    Browse the repository at this point in the history

  3. remove the "cancel on escape" behavior

    @Paril @mikke89
    Paril authored and mikke89 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b97d4b4 View commit details
    Browse the repository at this point in the history

  4. adjust names to match ElementDocument conventions

    @Paril @mikke89
    Paril authored and mikke89 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    19dbaea View commit details
    Browse the repository at this point in the history

  5. document DropDownBoxLayoutType

    @Paril @mikke89
    Paril authored and mikke89 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bb8ab0e View commit details
    Browse the repository at this point in the history

  6. Text widget changes (squash) 

    Use separate bool for layout_dirty vs box just opened, as these two states are not really mutually exclusive. Fixes a bug where the box was not considered just opened since the "open" state was overwritten by the "switch" state.

Use center vertical alignment for a just opened box. This is admittedly a subjective matter. However, it looked a bit weird to me how it would scroll past the first few elements when you select, say, just the second or third element. With center, both the first few, and the last items, are shown when selecting something near the beginning or the end respectively. This also feels more symmetrical when the selection box ends up being placed above the select element.
    @mikke89
    mikke89 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    13e210c View commit details
    Browse the repository at this point in the history