Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fileReadBytes external #868

Merged

Conversation

didrikmunther
Copy link
Contributor

@didrikmunther didrikmunther commented Oct 16, 2024

Adds the ability to read X amount of characters from a ReadChannel. Commonly required in protocols such as JSON-RPC to read the required amount of characters as specified by a Content-Length: X header.

@didrikmunther didrikmunther changed the title feat: Add readBytes Add readBytes external Oct 16, 2024
Copy link
Contributor

@marten-voorberg marten-voorberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad you figured it out.

I added a couple comments covering some very minor changes.

Rename tests for externals
@didrikmunther didrikmunther changed the title Add readBytes external Add fileReadBytes external Nov 22, 2024
@didrikmunther didrikmunther marked this pull request as draft November 26, 2024 20:50
@didrikmunther didrikmunther marked this pull request as ready for review November 26, 2024 21:22
@david-broman david-broman merged commit cbfaf4e into miking-lang:develop Dec 5, 2024
@didrikmunther didrikmunther deleted the didrik/feat/read-bytes branch December 5, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants