-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output gets cut off towards the bottom #7
Comments
Thanks for the feedback.
|
@musjj thanks for the screenshots.
nvim +'KittyScrollbackCheckHealth' +'quit!'
kitty @ get-text --ansi --extent=all | nvim kitty @ get-text --ansi --extent=all | sed -e "s/$/\x1b[0m/g" -e "s/\x1b\[\?25.\x1b\[.*;.*H\x1b\[.*//g" | nvim I'm trying to determine if this is coming from Kitty or if it is any of the processing in the plugin. |
I'm using zsh 5.9
Running
I'm getting mixed results with this, but I'm not really sure why. Most of the time It feels like there's some kind of race condition when it comes to piping large text content, either from the
I'm seeing similar inconsistencies here, but in this case I usually get a tiny bit of content (some kind of terminal escape). But if I repeat the command enough I can sometimes get the complete scrollback of the terminal. Sorry if there's a lot of vague-ness here, it's a weird issue. Can you reproduce this in your end? That might make debugging it easier. |
@musjj Thanks for the info. I'm not able to reproduce the issue. I'll experiment around but any info you have will be helpful 👍 |
Tried to make it more reproducible: base64 /dev/urandom | head -c 100000000
kitty @ get-text --ansi --extent=all | nvim -u NONE Try increading the |
Awesome, thanks for this. I was able to reproduce on an Ubuntu VM. I couldn't reproduce on MacOS. I think you are right about Kitty or Nvim having issues with the large stdout/stdin. I'll try and dig more into this later to get a better understanding and may open an upstream ticket. |
@musjj could you try base64 /dev/urandom | head -c 100000000
nvim -u NONE <<< $(kitty @ get-text --ansi --extent=all) This seems to work for me. This waits for the entire stdout before passing to NVIM. |
This one works for me, it captures the entire scrollback! Can this workaround be used for the plugin? |
Great. I'll have to make some changes but should be able to do it 👍 |
Hey @musjj just an update. Edit: not a Neovim bug, just came across undocumented values for |
@musjj so this is a tricky one 😂 . Ok I think I got it working now, would you mind doing a test with the branch fix-long-text-truncate ? I added a statement to explicitly flush the buffer to stdout. Not necessary, but you may also want to checkout the kitty option scrollback_pager_history_size if you want to increase the overall size of the scrollback. |
Tested it out and it works perfectly, thanks a lot for the fix! |
🥳 awesome. Thanks for reporting and helping reproduce 👍. I'll have it merged to main probably sometime tomorrow. |
🎉 This issue has been resolved in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
With a huge scrollback, (try running
ls -R
on a big directory), this scrollback displayed by this plugin will get cut off towards the bottom. I noticed the same issue happening with homebrew kitty pager scripts I've found in the wild.The text was updated successfully, but these errors were encountered: