-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redesign configuring kitty-scrollback.nvim #69
Comments
Surprisingly, I've found that just using
I personally would be happier, if this plugin would work a little more like firenvim (which I'm using to write this) in that it just loads the nvim gui into the program, but I can only assume that integrating neovim as a gui into another gui must be really complicated. |
That sounds like a bug. Could you create an issue for this with a screenshot and info on what plugin you are using for the dashboard? Most likely kitty-scrollback.nvim is having an issue because it expects an empty buffer.
This is actually passing Right now, I am planning to remove
I have not used firenvim but it does look nice. Right now, kitty-scrollback.nvim loads the scrollback buffer into nvim. I'm not sure how the other approach would differ that you mentioned. Thanks for the feedback! |
See here
That could explain it! Perhaps, would it be a good idea to pass some file name or path by default to bypass dashboards and other stuff that happens when
I'm not sure about the technicalities, but from my understanding, the "host" provides a gui window inside it's own gui, which is "inhabited" by a neovim. This would be pretty out of scope for this plugin, as it would probably require changes in kitty itself. So just ignore me :) |
closes #69 BREAKING CHANGE: kitty-scrollback.nvim loads your Neovim configuration by default. Previous versions of kitty-scrollback.nvim, did not load any configurations or plugins by default. - Previously, kitty-scrollback.nvim did not open Neovim with your Neovim configuration by default. This has changed to loading your Neovim configuration by default, with the ability to opt out. If you prefer to continue not loading your Neovim configuration, then follow the steps at [No Configuration](#no-configuration). - If you previously used the flag `--no-nvim-args`, then delete it from your configuration because it no longer has any effect. The flag `--nvim-args` remains unchanged and can still be used. - `ksb_example` configurations have been removed and can no longer be referenced by name. If you were previously referencing an example configuration by name, then you can manually copy it from [./tests/example.lua](./tests/example.lua) into your kitty-scrollback.nvim configuration. See [Plugin Configuration](#plugin-configuration) for detailed instructions on configuration kitty-scrollback.nvim. - The command `KittyScrollbackGenerateKittens` and api `generate_kittens` no longer have an option to generate `ksb_example` configurations. - The command `KittyScrollbackGenerateKittens` no longer accepts the bang `!` modifier - The api `generate_kittens` signature removed the `all` parameter - The reserved `global` configuration name has been removed and global options are now configured by the first element of the options table without a key. See [Global Configuration](#global-configuration) for more details. - The undocumented reserved `default` configuration name has been removed. kitty-scrollback.nvim defaults to `ksb_builtin_get_text_all` if no configuration is provided.
# [4.0.0](v3.2.1...v4.0.0) (2024-01-29) * feat!: redesign kitty-scrollback.nvim configuration (#118) ([97fea1b](97fea1b)), closes [#118](#118) [#69](#69) ### BREAKING CHANGES * kitty-scrollback.nvim loads your Neovim configuration by default. Previous versions of kitty-scrollback.nvim, did not load any configurations or plugins by default. - Previously, kitty-scrollback.nvim did not open Neovim with your Neovim configuration by default. This has changed to loading your Neovim configuration by default, with the ability to opt out. If you prefer to continue not loading your Neovim configuration, then follow the steps at [No Configuration](#no-configuration). - If you previously used the flag `--no-nvim-args`, then delete it from your configuration because it no longer has any effect. The flag `--nvim-args` remains unchanged and can still be used. - `ksb_example` configurations have been removed and can no longer be referenced by name. If you were previously referencing an example configuration by name, then you can manually copy it from [./tests/example.lua](./tests/example.lua) into your kitty-scrollback.nvim configuration. See [Plugin Configuration](#plugin-configuration) for detailed instructions on configuration kitty-scrollback.nvim. - The command `KittyScrollbackGenerateKittens` and api `generate_kittens` no longer have an option to generate `ksb_example` configurations. - The command `KittyScrollbackGenerateKittens` no longer accepts the bang `!` modifier - The api `generate_kittens` signature removed the `all` parameter - The reserved `global` configuration name has been removed and global options are now configured by the first element of the options table without a key. See [Global Configuration](#global-configuration) for more details. - The undocumented reserved `default` configuration name has been removed. kitty-scrollback.nvim defaults to `ksb_builtin_get_text_all` if no configuration is provided.
🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Important
If you have had any pain points configuring kitty-scrollback.nvim, please add a comment or suggestion.
Warning
Breaking change
Remove nvim defaults
--clean --noplugin -n
--no-nvim-args
or--nvim-args <args>
to read the kitty-scrollback.nvim configuration.--no-nvim-args
since it no longer applies--clean --noplugin -n
if desired. This is a breaking change and requires the user to configure if they want the existing functionality.Different configuration options:
global
,default
,ksb_builtin_*
,ksb_example_*
- Consider creating a symlink or copying thekitty_scrollback_nvim.py
kitten to Kitty's configuration directory to avoid absolute path inaction_alias kitty_scrollback_nvim
. See #114- Option: add to bootstrapping logic, try to do it in a generic way to support lazy/packer/pack/etc- Option: Add to the:KittyScrollbackGenerateKittens
command.- Option: Create a wrapper kitten that resolves the path and callskitty_scrollback_nvim.py
-Investigate: user uses environment variable or kitty --config could change path of kitty config directory?Consider making config options either a table of function instead of just a function
Related issues or discussions around configuring kitty-scrollback.nvim
The text was updated successfully, but these errors were encountered: