Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed autolink showing and added examples #159

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

regrowler
Copy link

Hi Mike. I noticed a problem while working with urls like in the example below.
<https://blog.mikepenz.dev/>
Markdown url syntax
In the current solution, it shown with brackets. I made a fix for that.
In Intellij's markdown parser it's called autolink. But for urls like in the markdown syntax, it has CompositeASTNode with 3 children.
One of them contains an autolink that does not equal MarkdownElementTypes.AUTOLINK due to it having the isToken property = true.
So, I implemented search of target element by element type name instead of getting all the text.
Also, I noticed that such kind of links doesn't have underscores if i use SquigglyUnderlineSpanPainter.
I believe this happens because of unspecified color for span style while building the string for autolinks.
Also, I added some autolink examples for test markdown strings in app, app-desktop and app-wasm.

@mikepenz mikepenz merged commit 530062f into mikepenz:develop Jun 7, 2024
@mikepenz
Copy link
Owner

mikepenz commented Jun 7, 2024

Thank you very much!

@mikepenz mikepenz added the fix label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants