Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: TDbConnection handling #757

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Bugfix: TDbConnection handling #757

merged 2 commits into from
Feb 2, 2021

Conversation

tommasobertoni
Copy link
Contributor

Use typeof(TDbConnection) for Add and Remove generic overloads.
Changes involve: DbHelperMapper, DbSettingMapper, StatementBuilderMapper.

Resolves #756.

@mikependon
Copy link
Owner

Thanks for this PR. :)

@mikependon mikependon merged commit 1d6229b into mikependon:master Feb 2, 2021
@mikependon
Copy link
Owner

Btw, is there a way we can utilize the IsSubClassOf() method or something similar?

@tommasobertoni
Copy link
Contributor Author

Btw, is there a way we can utilize the IsSubClassOf() method or something similar?

@mikependon what do you mean with that?

@mikependon
Copy link
Owner

Ooopss, forget about my comment above. Thanks for this PR mate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: DbSettingMapper adds DbConnection instead of TDbConnection
2 participants
@tommasobertoni @mikependon