Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Create a base class for the Type Map attributes (NpgsqlTypeMapAttribute, MySqlTypeMapAttribute, MicrosoftSqlServerTypeMapAttribute and SystemSqlServerTypeMapAttribute) #873

Closed
mikependon opened this issue Sep 9, 2021 · 1 comment
Closed

Enhancement: Create a base class for the Type Map attributes (NpgsqlTypeMapAttribute, MySqlTypeMapAttribute, MicrosoftSqlServerTypeMapAttribute and SystemSqlServerTypeMapAttribute) #873

mikependon opened this issue Sep 9, 2021 · 1 comment
Assignees
@mikependon
Labels
deployed Feature or bug is deployed at the current release enhancement New feature or request fixed The bug, issue, incident has been fixed.

Comments

@mikependon
Copy link
Owner

mikependon commented Sep 9, 2021 •
edited
Loading

Describe the enhancement

To simplify the compilation and provide more dynamics to the entity class itself, it is good to create a base class for the Type Map attributes (NpgsqlTypeMapAttribute, MySqlTypeMapAttribute, MicrosoftSqlServerTypeMapAttribute and SystemSqlServerTypeMapAttribute).

This base class is only not limited to the mentioned type map attributes, it should as well be able to set the value of all the property of the IDbDataParameter object.

This should not impact the existing implementations.
@mikependon mikependon added the enhancement New feature or request label Sep 9, 2021
@mikependon mikependon self-assigned this Sep 9, 2021
@mikependon mikependon changed the title Enhancement: Create a DbTypeMapAttribute as the base class of the Type Map attributes (NpgsqlTypeMapAttribute, MySqlTypeMapAttribute, MicrosoftSqlServerTypeMapAttribute and SystemSqlServerTypeMapAttribute) Enhancement: Create a base class for the Type Map attributes (NpgsqlTypeMapAttribute, MySqlTypeMapAttribute, MicrosoftSqlServerTypeMapAttribute and SystemSqlServerTypeMapAttribute) Sep 10, 2021
mikependon added a commit that referenced this issue Sep 10, 2021
@mikependon
#873 Added a base class for the DbParameter property value setter.
b0940a9
@mikependon mikependon added fixed The bug, issue, incident has been fixed. and removed fixed The bug, issue, incident has been fixed. labels Sep 10, 2021
@mikependon mikependon pinned this issue Sep 10, 2021
mikependon added a commit that referenced this issue Sep 10, 2021
@mikependon
Merge pull request #875 from mikependon/repodb-dbparameter-propertyva…
8d1863e 
…luesetter

#873 Added a base class for the DbParameter property value setter.
@mikependon mikependon added the fixed The bug, issue, incident has been fixed. label Sep 11, 2021
@mikependon
Copy link
Owner Author

This will be available on the version > v1.12.8-beta4.

@mikependon mikependon unpinned this issue Sep 11, 2021
@mikependon mikependon added the deployed Feature or bug is deployed at the current release label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikependon mikependon

Labels
deployed Feature or bug is deployed at the current release enhancement New feature or request fixed The bug, issue, incident has been fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikependon